Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #96753

Closed

Commits on May 3, 2022

  1. Configuration menu
    Copy the full SHA
    7907385 View commit details
    Browse the repository at this point in the history
  2. Collect function instance used in global_asm! sym operand

    The constants used in SymFn operands have FnDef type,
    so the type of the constant identifies the function.
    tmiasko committed May 3, 2022
    Configuration menu
    Copy the full SHA
    e626634 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Configuration menu
    Copy the full SHA
    13b45aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb131d2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c8a2d4 View commit details
    Browse the repository at this point in the history
  4. Use STARTS_WITH, since it's more specific

    Co-Authored-By: Guillaume Gomez <[email protected]>
    notriddle and GuillaumeGomez committed May 5, 2022
    Configuration menu
    Copy the full SHA
    345a580 View commit details
    Browse the repository at this point in the history
  5. rustdoc: change the "In Function Signatures" to context-sensitive

    * If it's just `-> a`, use "In Function Return Types"
    * If it's just `a b`, use "In Function Parameters"
    * Otherwise, still use "In Function Signatures"
    notriddle committed May 5, 2022
    Configuration menu
    Copy the full SHA
    21a1213 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8b2147b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    75790fa View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4c183cd View commit details
    Browse the repository at this point in the history
  9. Improve settings loading strategy by loading CSS and JS at the same t…

    …ime to prevent the style to be applied afterwards on slow connections
    GuillaumeGomez committed May 5, 2022
    Configuration menu
    Copy the full SHA
    87b6326 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2ed38cd View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Put the 2229 migration errors in alphabetical order

    Looks like they were in FxHash order before, so it might just be luck that this used to be consistent across different word lengths.
    scottmcm committed May 6, 2022
    Configuration menu
    Copy the full SHA
    30309db View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#96094 - Elliot-Roberts:fix_doctests, r=comp…

    …iler-errors
    
    Begin fixing all the broken doctests in `compiler/`
    
    Begins to fix rust-lang#95994.
    All of them pass now but 24 of them I've marked with `ignore HELP (<explanation>)` (asking for help) as I'm unsure how to get them to work / if we should leave them as they are.
    There are also a few that I marked `ignore` that could maybe be made to work but seem less important.
    Each `ignore` has a rough "reason" for ignoring after it parentheses, with
    
    - `(pseudo-rust)` meaning "mostly rust-like but contains foreign syntax"
    - `(illustrative)` a somewhat catchall for either a fragment of rust that doesn't stand on its own (like a lone type), or abbreviated rust with ellipses and undeclared types that would get too cluttered if made compile-worthy.
    - `(not-rust)` stuff that isn't rust but benefits from the syntax highlighting, like MIR.
    - `(internal)` uses `rustc_*` code which would be difficult to make work with the testing setup.
    
    Those reason notes are a bit inconsistently applied and messy though. If that's important I can go through them again and try a more principled approach. When I run `rg '```ignore \(' .` on the repo, there look to be lots of different conventions other people have used for this sort of thing. I could try unifying them all if that would be helpful.
    
    I'm not sure if there was a better existing way to do this but I wrote my own script to help me run all the doctests and wade through the output. If that would be useful to anyone else, I put it here: https://github.com/Elliot-Roberts/rust_doctest_fixing_tool
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    7a983ad View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#96590 - notriddle:notriddle/tab-bar-fn-sear…

    …ch, r=GuillaumeGomez,jsha
    
    rustdoc: when running a function-signature search, tweak the tab bar
    
    # Before
    
    ![In Names (7) / In Parameters (0) / In Return types (0)](https://user-images.githubusercontent.com/1593513/166122875-ffdeafe6-8d4d-4e61-84a6-f5986b50ac35.png)
    
    # After
    
    ![In Function Signature (7)](https://user-images.githubusercontent.com/1593513/166122883-9a3d7515-3235-4ee3-8c4b-5401d109e099.png)
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    f32a3d6 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#96650 - tmiasko:global-asm-sym-fn, r=Amanieu

    Collect function instance used in `global_asm!` sym operand
    
    The constants used in SymFn operands have FnDef type,
    so the type of the constant identifies the function.
    
    Fixes rust-lang#96623.
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    149ab39 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#96704 - GuillaumeGomez:rotation-animation, …

    …r=jsha
    
    Add rotation animation on settings button when loading
    
    As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the `settings.js` super long so we can see what the animation looks like):
    
    https://user-images.githubusercontent.com/3050060/166693243-816a08b7-5e39-4142-acd3-686ad9950d8e.mp4
    
    r? ```@jsha```
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    0631930 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96730 - JohnTitor:unused-lifetimes-tests, r…

    …=compiler-errors
    
    Add a regression test for rust-lang#64173 and rust-lang#66152
    
    Closes rust-lang#64173
    Closes rust-lang#66152
    
    Mixed the code as the root cause seems the same.
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    3cda519 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#96741 - GuillaumeGomez:improve-settings-loa…

    …ding-strategy, r=jsha
    
    Improve settings loading strategy
    
    I learned about this thanks to ``@jsha`` who suggested this approach:
    
    It improves the settings loading strategy by loading CSS and JS at the same time to prevent the style to be applied afterwards on slow connections.
    
    r? ``@jsha``
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    c5abe2d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#96747 - JohnTitor:expect-local-track-caller…

    …, r=compiler-errors
    
    Add `track_caller` to `DefId::expect_local()`
    
    Suggested in rust-lang#96738 (comment).
    `DefId::expect_local()` often causes ICEs (panics) and should be a good candidate to add `track_caller`.
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    5a2fbcf View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#96752 - scottmcm:error-sorting, r=compiler-…

    …errors
    
    Put the incompatible_closure_captures lint messages in alphabetical order
    
    Looks like they were in hash order before, which was causing me trouble in rust-lang#94598, so this PR sorts the errors by trait name.
    compiler-errors authored May 6, 2022
    Configuration menu
    Copy the full SHA
    3fd498a View commit details
    Browse the repository at this point in the history