Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the rustdoc-contributors team #1040

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

GuillaumeGomez
Copy link
Member

Creating this subteam will allow to finally give recognition to @fmease's work and also give them access to our tools.

Please don't merge until the rustdoc team gave its approval. The discussion for this PR is here.

cc @rust-lang/rustdoc

rylev
rylev previously approved these changes Aug 10, 2023
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm unsure about the need for crater though. It would be nice to limit who has access to crater runs (since they are not cheap to run).

teams/rustdoc-contributors.toml Outdated Show resolved Hide resolved
[permissions]
crater = true
bors.rust.review = true
dev-desktop = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jdno for awareness.

@fmease
Copy link
Member

fmease commented Aug 10, 2023

It's unfortunate that we can't have subsubteams (rustdoc-contributors < rustdoc < devtools) but I guess that goes overboard. I wonder what can be done about it. If we made it a subteam of devtools instead as GuillaumeGomez has suggested to me, would that work? Not sure if the ping groups would be set up correctly in such case (pinging rustdoc should ideally ping rustdoc-contributors, too, right?).

@rylev
Copy link
Member

rylev commented Aug 10, 2023

I think we want the ability for subteams to have subteams. cc @Mark-Simulacrum and @pietroalbini for thoughts on why we can't just remove this limitation.

@pietroalbini
Copy link
Member

That'd break the website right now I think.

@GuillaumeGomez
Copy link
Member Author

I can take a look at the website if needed.

@fmease
Copy link
Member

fmease commented Aug 10, 2023

I guess subteams of subteams should get laid out flat below their parent team, that looks like the most straightforward solution.
This way, Rustdoc team contributors gets placed below Rustdoc team over at https://www.rust-lang.org/governance/teams/dev-tools.

@jsha
Copy link

jsha commented Aug 16, 2023

I gave feedback on the Zulip thread but to put it here too: I support this.

@fmease
Copy link
Member

fmease commented Aug 17, 2023

I've now opened #1046 (hard blocker) and rust-lang/www.rust-lang.org#1854 (soft blocker).

The creation of rust-contributors has been pretty much approved (6 explicit approvals, 1 pending approval).

@fmease
Copy link
Member

fmease commented Aug 19, 2023

Alright, 7 out of 7 rustdoc team members approve (see linked Zulip topic) 🎉 Thanks everyone!

@fmease
Copy link
Member

fmease commented Aug 28, 2023

Since #1046 (Permit subteams to have subteams) is now merged, could somebody kick off a CI run? Thanks!
Once it's green, this PR should be ready to be merged, right? As far as I can tell, it's sufficiently approved :)

@rylev
Copy link
Member

rylev commented Aug 28, 2023

@GuillaumeGomez can you rebase this against the new version of master?

@GuillaumeGomez
Copy link
Member Author

Rebased.

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rylev rylev merged commit f687023 into rust-lang:master Aug 29, 2023
1 check passed
@GuillaumeGomez GuillaumeGomez deleted the rustdoc-contributors-team branch August 29, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants