-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the rustdoc-contributors team #1040
Create the rustdoc-contributors team #1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm unsure about the need for crater though. It would be nice to limit who has access to crater runs (since they are not cheap to run).
[permissions] | ||
crater = true | ||
bors.rust.review = true | ||
dev-desktop = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jdno for awareness.
73a827a
to
d5796d9
Compare
It's unfortunate that we can't have subsubteams (rustdoc-contributors < rustdoc < devtools) but I guess that goes overboard. I wonder what can be done about it. If we made it a subteam of devtools instead as GuillaumeGomez has suggested to me, would that work? Not sure if the ping groups would be set up correctly in such case (pinging rustdoc should ideally ping rustdoc-contributors, too, right?). |
I think we want the ability for subteams to have subteams. cc @Mark-Simulacrum and @pietroalbini for thoughts on why we can't just remove this limitation. |
That'd break the website right now I think. |
I can take a look at the website if needed. |
I guess subteams of subteams should get laid out flat below their parent team, that looks like the most straightforward solution. |
I gave feedback on the Zulip thread but to put it here too: I support this. |
I've now opened #1046 (hard blocker) and rust-lang/www.rust-lang.org#1854 (soft blocker). The creation of rust-contributors has been pretty much approved (6 explicit approvals, 1 pending approval). |
Alright, 7 out of 7 rustdoc team members approve (see linked Zulip topic) 🎉 Thanks everyone! |
d5796d9
to
78a6aec
Compare
Since #1046 (Permit subteams to have subteams) is now merged, could somebody kick off a CI run? Thanks! |
@GuillaumeGomez can you rebase this against the new version of master? |
78a6aec
to
52a9351
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Creating this subteam will allow to finally give recognition to @fmease's work and also give them access to our tools.
Please don't merge until the rustdoc team gave its approval. The discussion for this PR is here.
cc @rust-lang/rustdoc