Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team: add a new wg for rust macros #1052

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

vincenzopalazzo
Copy link
Member

@vincenzopalazzo vincenzopalazzo commented Aug 21, 2023

This is adding a new team that is the wg-macros
as a followup step after the MCP get merged [1].

[1] rust-lang/compiler-team#637

CohenArthur added a commit to CohenArthur/rust-teams that referenced this pull request Aug 28, 2023
vincenzopalazzo pushed a commit to vincenzopalazzo/team that referenced this pull request Aug 28, 2023
@vincenzopalazzo
Copy link
Member Author

Ok including the #1055 inside this PR

I also fixed the review from @compiler-errors thanks to point me out this change

vincenzopalazzo pushed a commit to vincenzopalazzo/team that referenced this pull request Aug 28, 2023
@vincenzopalazzo vincenzopalazzo marked this pull request as ready for review August 28, 2023 13:42
vincenzopalazzo and others added 3 commits August 28, 2023 15:50
This is adding a new team that is the wg-macros
as a folloup step after the MCP get merged [1].

[1] rust-lang/compiler-team#637

Signed-off-by: Vincenzo Palazzo <[email protected]>
@rylev
Copy link
Member

rylev commented Aug 29, 2023

r? @wesleywiser @davidtwco

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

Copy link
Member

@jhpratt jhpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@pietroalbini pietroalbini merged commit 4099712 into rust-lang:master Sep 11, 2023
1 check passed
@vincenzopalazzo vincenzopalazzo deleted the macros/macros-wg branch September 11, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants