-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
team: add a new wg for rust macros #1052
Merged
pietroalbini
merged 3 commits into
rust-lang:master
from
vincenzopalazzo:macros/macros-wg
Sep 11, 2023
Merged
team: add a new wg for rust macros #1052
pietroalbini
merged 3 commits into
rust-lang:master
from
vincenzopalazzo:macros/macros-wg
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
added a commit
to CohenArthur/rust-teams
that referenced
this pull request
Aug 28, 2023
vincenzopalazzo
pushed a commit
to vincenzopalazzo/team
that referenced
this pull request
Aug 28, 2023
Ok including the #1055 inside this PR I also fixed the review from @compiler-errors thanks to point me out this change |
vincenzopalazzo
pushed a commit
to vincenzopalazzo/team
that referenced
this pull request
Aug 28, 2023
vincenzopalazzo
force-pushed
the
macros/macros-wg
branch
from
August 28, 2023 13:42
30d7a09
to
9d4aee0
Compare
This is adding a new team that is the wg-macros as a folloup step after the MCP get merged [1]. [1] rust-lang/compiler-team#637 Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/macros-wg
branch
from
August 28, 2023 13:50
4c708a6
to
2c21fba
Compare
wesleywiser
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉
jhpratt
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM
pietroalbini
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding a new team that is the wg-macros
as a followup step after the MCP get merged [1].
[1] rust-lang/compiler-team#637