Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch triagebot team to maintain role #1095

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 13, 2023

This upgrades the triagebot team's permission role from write to maintain so that they are able to merge PRs. GitHub's default branch protection behavior is to only allow people with the maintain role to merge PRs. The permission differences are:

  • Edit a repository's description
  • Enable wikis and restrict wiki editors
  • Enable project boards
  • Configure pull request merges
  • Configure a publishing source for GitHub Pages
  • Push to protected branches
  • Create tags that match a tag protection rule
  • Create and edit repository social cards
  • Enable GitHub Discussions in a repository

None of which I think are all that important to restrict (at least for this particular repo).

We could change it so that sync-team automatically includes people with the "write" role to be allowed to merge PRs. Or alternatively, to have a specific opt-in (like allow-write-role=true). However, I am not feeling inclined to hack on sync-team right now, and it would change permissions for backtrace-rs (adds alexcrichton), flate2 (adds brson), and impl-trait-utils (adds wg-async), which I don't want to fuss with.

Another option is to drop the branch protection, but at least I feel more comfortable with it enabled since it requires everything to go through a PR which is more publicly visible.

Also, just in general, it looks like we have been giving out maintain to almost all repos anyways.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this makes sense, and is a reasonable first point even if we do adjust branch protections in the future.

@Mark-Simulacrum Mark-Simulacrum merged commit be1e2a4 into rust-lang:master Oct 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants