Switch triagebot team to maintain role #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the triagebot team's permission role from
write
tomaintain
so that they are able to merge PRs. GitHub's default branch protection behavior is to only allow people with themaintain
role to merge PRs. The permission differences are:None of which I think are all that important to restrict (at least for this particular repo).
We could change it so that sync-team automatically includes people with the "write" role to be allowed to merge PRs. Or alternatively, to have a specific opt-in (like
allow-write-role=true
). However, I am not feeling inclined to hack on sync-team right now, and it would change permissions for backtrace-rs (adds alexcrichton), flate2 (adds brson), and impl-trait-utils (adds wg-async), which I don't want to fuss with.Another option is to drop the branch protection, but at least I feel more comfortable with it enabled since it requires everything to go through a PR which is more publicly visible.
Also, just in general, it looks like we have been giving out
maintain
to almost all repos anyways.