-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs-rs-reviewers team for review assignment #1107
Conversation
cc @rust-lang/docs-rs |
I'm curious, why not use triagebot to handle assignments and labels? |
I didn't dig into triagebot yet, and only continued what was already there. Will check it out. My understanding is that I would still need the separate group as github team so it could be assigned. |
Triagebot supports defining its own groups which can be used for assignment. Or, you can just list the names as a glob or fallback. For example: [assign.owners]
"*" = ["@GuillaumeGomez", "@Nemo157", "@syphar"] I'm not sure if there is really a need to define a distinct group, but if you want to be able to re-roll an assignment (like [assign.adhoc_groups]
docs-rs-reviewers = ["@GuillaumeGomez", "@Nemo157", "@syphar"]
[assign.owners]
"*" = ["docs-rs-reviewers"] |
re-roll sounds like there would be only one of the group members assigned (sorry for the questions, I don't have much experience with our codebases outside crates.io & docs.rs, or simpleinfra / rustwide. I would love to have a github team to assign or mention |
Is there something missing here on this PR? Or is there an alternative I'm missing when I would like to have a github team to assign to? |
1bb68a6
to
744a629
Compare
@rylev it seems like I have to add permissions to the team to see the docs.rs repository to be able to assign it as reviewer. Since the repo doesn't seem to be managed by this repo, can you add the access? Or someone else? |
@syphar added the team, but would you mind moving the docs.rs repo over to be controlled by the team repo? That would be a huge help! |
related docs.rs PR is: rust-lang/docs.rs#2283
I want to automatically a github team as reviewer for pull requests, and not everyone in the docs.rs team regularly reviews.