Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs-rs-reviewers team for review assignment #1107

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Nov 4, 2023

related docs.rs PR is: rust-lang/docs.rs#2283

I want to automatically a github team as reviewer for pull requests, and not everyone in the docs.rs team regularly reviews.

@syphar
Copy link
Member Author

syphar commented Nov 4, 2023

cc @rust-lang/docs-rs

@ehuss
Copy link
Contributor

ehuss commented Nov 4, 2023

I'm curious, why not use triagebot to handle assignments and labels?

@syphar
Copy link
Member Author

syphar commented Nov 5, 2023

I'm curious, why not use triagebot to handle assignments and labels?

I didn't dig into triagebot yet, and only continued what was already there. Will check it out.

My understanding is that I would still need the separate group as github team so it could be assigned.

@ehuss
Copy link
Contributor

ehuss commented Nov 5, 2023

Triagebot supports defining its own groups which can be used for assignment. Or, you can just list the names as a glob or fallback. For example:

[assign.owners]
"*" = ["@GuillaumeGomez", "@Nemo157", "@syphar"]

I'm not sure if there is really a need to define a distinct group, but if you want to be able to re-roll an assignment (like r? docs-rs-reviewers), then you can define a group with:

[assign.adhoc_groups]
docs-rs-reviewers = ["@GuillaumeGomez", "@Nemo157", "@syphar"]

[assign.owners]
"*" = ["docs-rs-reviewers"]

@syphar
Copy link
Member Author

syphar commented Nov 5, 2023

re-roll sounds like there would be only one of the group members assigned (sorry for the questions, I don't have much experience with our codebases outside crates.io & docs.rs, or simpleinfra / rustwide.

I would love to have a github team to assign or mention

@syphar
Copy link
Member Author

syphar commented Nov 15, 2023

Is there something missing here on this PR?

Or is there an alternative I'm missing when I would like to have a github team to assign to?

teams/docs-rs-reviewers.toml Outdated Show resolved Hide resolved
@rylev rylev merged commit d1ae882 into rust-lang:master Nov 24, 2023
1 check passed
@syphar syphar deleted the dosc-rs-reviewers branch November 24, 2023 12:12
@syphar
Copy link
Member Author

syphar commented Nov 24, 2023

@rylev it seems like I have to add permissions to the team to see the docs.rs repository to be able to assign it as reviewer.

Since the repo doesn't seem to be managed by this repo, can you add the access? Or someone else?

@rylev
Copy link
Member

rylev commented Nov 27, 2023

@syphar added the team, but would you mind moving the docs.rs repo over to be controlled by the team repo? That would be a huge help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants