Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give t-libs dev-desktop permissions #1108

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Nov 4, 2023

I'd like to give myself dev-desktop permissions. I'm on several teams so hopefully this isn't a problem, even though none of them already have it (although it's a bit surprising that this is true for t-libs). Edit: I've changed this to grant dev-desktop to t-libs broadly.

I haven't asked anywhere if this is okay, so let me know if I'm skipping some process.

@compiler-errors
Copy link
Member

compiler-errors commented Nov 4, 2023

I think all T-libs deserve access to cloud desktops. If you don't want to amend this PR to make that so, I'll open up a follow-up.

@thomcc thomcc changed the title Give thomcc dev-desktop permissions Give t-libs dev-desktop permissions Nov 4, 2023
@thomcc
Copy link
Member Author

thomcc commented Nov 4, 2023

I've pushed a commit that makes that change, and edited the PR title/desc accordingly. I can easily revert it if this would take much more time to push through, tho (like if it'd take an FCP to grant for libs but not for me, I'd prefer to do it separately, not that I care that much).

@rylev
Copy link
Member

rylev commented Nov 6, 2023

r? @jdno

@Mark-Simulacrum Mark-Simulacrum merged commit f2548ea into rust-lang:master Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants