Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add less-recent libs-api alumni #1123

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

@rylev
Copy link
Member

rylev commented Nov 27, 2023

Hmm.. I also believe these people are alumni of many other teams. Do we currently require that people on the alumni team are not explicitly alumni of any team? Otherwise, it might make sense to keep them on the alumni team for now.

@dtolnay
Copy link
Member Author

dtolnay commented Nov 27, 2023

CI failed when I tried to add them to libs-api alumni without removing from the legacy alumni team.

[ERROR rust_team::validate] validation error: alumni team explicitly includes member 'Kimundi' who was specified as an alumni already in 'libs-api'
[ERROR rust_team::validate] validation error: alumni team explicitly includes member 'aturon' who was specified as an alumni already in 'libs-api'
[ERROR rust_team::validate] validation error: alumni team explicitly includes member 'brson' who was specified as an alumni already in 'libs-api'
[ERROR rust_team] 3 validation errors found

I'd be happy to do one of:

  1. Delete the above check and keep them on the alumni team, as you said. This gets them credited on https://www.rust-lang.org/governance/teams/library#libs-api without implying it's their only contribution.

  2. Comment out their entries in the alumni team, rather than deleting.

  3. Populate a guess of other teams based on what's in 2e0e782 and rust-lang/prev.rust-lang.org@27696a3. That would be:

    • alexcrichton: cargo, core, infra, release
    • aturon: core, lang
    • brson: core, devtools, infra, community, style
  4. Ping them in an issue to request a list of teams they associate with.

@rylev
Copy link
Member

rylev commented Nov 27, 2023

Option 1 doesn't seem appropriate as deleting the check risks us reverting back to populating the alumni team which we don't want to do. Option 2 also doesn't seem worth it as it is sort of the disadvantages of all the approaches with only a small upside.

I think doing both 3 and 4 would be best. If we get a response from anyone I'd be happy to make a follow up PR adding them to any additional alumni teams.

@dtolnay
Copy link
Member Author

dtolnay commented Nov 27, 2023

FYI @alexcrichton @aturon @brson @Gankra @huonw @Kimundi — hopefully this looks okay to you. You'll start to appear under "Alumni" on https://www.rust-lang.org/governance/teams/library#libs-api as well as the other teams modified in this PR.

With the exception of Alex and Gankra since they are current members of other teams, you will continue to appear on https://www.rust-lang.org/governance/teams/alumni as well.

…lumni already in 'libs-api'"

     [WARN  rust_team::validate] couldn't perform checks relying on the Zulip API, some errors will not be detected
     [WARN  rust_team::validate] cause: missing ZULIP_USER and/or ZULIP_TOKEN environment variables
     [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'Kimundi' who was specified as an alumni already in 'libs-api'
     [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'aturon' who was specified as an alumni already in 'libs-api'
     [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'brson' who was specified as an alumni already in 'libs-api'
     [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'huonw' who was specified as an alumni already in 'libs-api'
     [ERROR rust_team] 4 validation errors found
@rylev rylev merged commit b77b817 into rust-lang:master Nov 27, 2023
1 check passed
@dtolnay dtolnay deleted the libalumni branch November 27, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants