-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add less-recent libs-api alumni #1123
Conversation
Hmm.. I also believe these people are alumni of many other teams. Do we currently require that people on the alumni team are not explicitly alumni of any team? Otherwise, it might make sense to keep them on the alumni team for now. |
CI failed when I tried to add them to libs-api alumni without removing from the legacy alumni team. [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'Kimundi' who was specified as an alumni already in 'libs-api'
[ERROR rust_team::validate] validation error: alumni team explicitly includes member 'aturon' who was specified as an alumni already in 'libs-api'
[ERROR rust_team::validate] validation error: alumni team explicitly includes member 'brson' who was specified as an alumni already in 'libs-api'
[ERROR rust_team] 3 validation errors found I'd be happy to do one of:
|
Option 1 doesn't seem appropriate as deleting the check risks us reverting back to populating the alumni team which we don't want to do. Option 2 also doesn't seem worth it as it is sort of the disadvantages of all the approaches with only a small upside. I think doing both 3 and 4 would be best. If we get a response from anyone I'd be happy to make a follow up PR adding them to any additional alumni teams. |
FYI @alexcrichton @aturon @brson @Gankra @huonw @Kimundi — hopefully this looks okay to you. You'll start to appear under "Alumni" on https://www.rust-lang.org/governance/teams/library#libs-api as well as the other teams modified in this PR. With the exception of Alex and Gankra since they are current members of other teams, you will continue to appear on https://www.rust-lang.org/governance/teams/alumni as well. |
…lumni already in 'libs-api'" [WARN rust_team::validate] couldn't perform checks relying on the Zulip API, some errors will not be detected [WARN rust_team::validate] cause: missing ZULIP_USER and/or ZULIP_TOKEN environment variables [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'Kimundi' who was specified as an alumni already in 'libs-api' [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'aturon' who was specified as an alumni already in 'libs-api' [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'brson' who was specified as an alumni already in 'libs-api' [ERROR rust_team::validate] validation error: alumni team explicitly includes member 'huonw' who was specified as an alumni already in 'libs-api' [ERROR rust_team] 4 validation errors found
Evidence:
rust-lang/rust#40673 (comment)
rust-lang/prev.rust-lang.org@a31408b#diff-7519aafe48e2ca696efec05f9bba9c9037718d4b4f9f9f032a666af5f9a3bc84R76-R92