Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kupiakos.toml, add to wg-binary-size #1141

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

kupiakos
Copy link
Contributor

@kupiakos kupiakos commented Dec 6, 2023

See rust-lang/wg-binary-size#4. I've already talked with @tgross35

@tgross35
Copy link
Contributor

tgross35 commented Dec 7, 2023

Sorry, when did you talk to me? Maybe I'm getting my screen names mixed up 🙂

I think @thomcc needs to approve this anyway as project lead (maybe that's who you meant)

@kupiakos
Copy link
Contributor Author

kupiakos commented Dec 7, 2023

Oh yes, my apologies, that is who I meant. I had used your PR to join as a template which he had linked and I had confused for his own.

@jackh726
Copy link
Member

r? @thomcc @m-ou-se

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've been away on vacation for the past 3 weeks.

This looks fine.

@Kobzol
Copy link
Contributor

Kobzol commented Jan 7, 2024

CC @jackh726 (I saw you approve a newer PR, so not sure if you got the notif. that this was approved by thomcc :) ).

@rylev rylev merged commit afd3a1a into rust-lang:master Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants