Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alumni field non-optional #1151

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Dec 17, 2023

// Teams must contain an `alumni = […]` field (even if empty) so that there
// is an obvious place to move contributors within the same file when
// removing from `members`.
//
// Marker teams are exempt from this, as well as teams which comprise only
// members of other teams via `include-team-leads` or similar; they do not
// need `alumni = […]`. For these teams, the correct place to put alumni is
// in the same team they're being included from.

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Can we add a note about this requirement to https://github.com/rust-lang/team/blob/master/docs/toml-schema.md?

@dtolnay
Copy link
Member Author

dtolnay commented Dec 18, 2023

Sure thing, good call. Done.

@rylev rylev merged commit 6cbd3d0 into rust-lang:master Dec 19, 2023
1 check passed
@dtolnay dtolnay deleted the alumni branch December 19, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants