Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crates-io-admins team #1158

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 3, 2024

This is a marker team that defines the group of people that are granted admin access on crates.io. Once the PR is merged we can implement a regular background job on the crates.io side that syncs the team repo into the crates.io user database.

Related:

@@ -0,0 +1,7 @@
name = "crates-io-admins"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to write a comment on what this team is supposed to be the admins of. It took me a second to realize that this was supposed to be for administration of crates.io itself even if in retrospect that is pretty obvious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a small comment. Does that match what you had in mind?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@rylev rylev merged commit 74d70bc into rust-lang:master Jan 3, 2024
1 check passed
@Turbo87 Turbo87 deleted the crates-io-admins branch January 11, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants