Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team affiliation for leadership council representatives #1182

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 8, 2024

Screenshot from 2024-01-08 13-50-37

Closes #1014.

Comment on lines 6 to 13
{ github = "carols10cents", roles = ["council-rep-crates-io"] },
{ github = "eholk", roles = ["council-rep-compiler"] },
{ github = "ehuss", roles = ["council-rep-devtools"] },
{ github = "jackh726", roles = ["council-rep-lang"] },
{ github = "jonathanpallant", roles = ["council-rep-launching-pad"] },
{ github = "Mark-Simulacrum", roles = ["council-rep-release"] },
{ github = "m-ou-se", roles = ["council-rep-libs"] },
{ github = "rylev", roles = ["council-rep-infra"] },
{ github = "technetos", roles = ["council-rep-mods"] },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also #1058 / #1059.

@dtolnay dtolnay marked this pull request as draft January 8, 2024 21:52
@dtolnay
Copy link
Member Author

dtolnay commented Jan 8, 2024

Marking as draft to sequence this after #1181.

rylev
rylev previously approved these changes Jan 9, 2024
@dtolnay
Copy link
Member Author

dtolnay commented Jan 9, 2024

Now waiting on rust-lang/www.rust-lang.org#1905.

@dtolnay
Copy link
Member Author

dtolnay commented Jan 18, 2024

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @dtolnay shall we merge this or are you still waiting on website changes?

@dtolnay
Copy link
Member Author

dtolnay commented Jan 19, 2024

This is ready to merge now.

It just won't immediately appear because deploys are broken (rust-lang/www.rust-lang.org#1917).

@rylev rylev merged commit d21def7 into rust-lang:master Jan 19, 2024
1 check passed
@dtolnay dtolnay deleted the councilroles branch January 19, 2024 11:17
@dtolnay
Copy link
Member Author

dtolnay commented Jan 19, 2024

Here it is on staging, for now: https://rust-www-staging.herokuapp.com/governance/teams/leadership-council 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Indicate the representation of Leadership Council members
3 participants