Add support for removing users' names upon request #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be better to map them to a single invalid user via the |
|
I kept them separate so that if there are others in the future, they're not incorrectly merged into a single person. This maintains the positions and numbers more accurately. I'll update this when I get a chance to factor in the mailmap update from you. |
Manishearth
reviewed
Sep 9, 2023
| use mailmap::Author; | ||
|
|
||
| lazy_static::lazy_static! { | ||
| static ref REMOVED: HashSet<mailmap::Author> = HashSet::from_iter([ |
There was a problem hiding this comment.
nit: probably add a comment linking to the teams repo PR so this can be found again when someone inevitably asks what this is for in a couple years
There was a problem hiding this comment.
Oddly enough I intended to do this and totally forgot.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 11, 2023
…oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Sep 11, 2023
…oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 11, 2023
…oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2023
Rollup merge of rust-lang#115702 - jonas-schievink:update-mailmap, r=oli-obk Update mailmap rust-lang/team#1071 / rust-lang/thanks#58
|
Given that updating the mailmap seems to handle this in an identical manner, I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/team#1071
I did not do anything about this user having four instances, as that's completely up to the
.mailmap, which is not included in this repository.What this PR does is maintains a list of name-email pairs that have been requested to be removed. If it matches, "[removed]" is output instead of the person's name. Per the user's request, that seems to be sufficient. I'm not sure what else could be done, as the history does exist in git.
Note that this does not remove the entry altogether; it merely removes the name from being displayed.