Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .set_sign() and Mul<Sign>/MulAssign<Sign> for BigInt #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

virchau13
Copy link

An attempt at solving #226. Adds .set_sign() and Mul<Sign>/MulAssign<Sign> for BigInt.

The current behaviour is that .set_sign(s) sets the sign if s is either Plus or Minus. If s is NoSign, the BigInt is set to zero. Mul<Sign>/MulAssign<Sign> is equivalent to self.set_sign(self.sign() * self.rhs), using the already-present impl Mul<Sign> for Sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant