-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Common feed format #5
Open
porglezomp
wants to merge
17
commits into
rust-syndication:master
Choose a base branch
from
porglezomp:feature/common-format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Common feed format #5
porglezomp
wants to merge
17
commits into
rust-syndication:master
from
porglezomp:feature/common-format
Commits on Jun 14, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3680f0b - Browse repository at this point
Copy the full SHA 3680f0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bd1a24 - Browse repository at this point
Copy the full SHA 9bd1a24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 430b25b - Browse repository at this point
Copy the full SHA 430b25bView commit details -
Add conversions between our Entry and Atom's Entry
Use the Entry conversions in the Atom Feed conversions
Configuration menu - View commit details
-
Copy full SHA for d61ea41 - Browse repository at this point
Copy the full SHA d61ea41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 541e898 - Browse repository at this point
Copy the full SHA 541e898View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa946de - Browse repository at this point
Copy the full SHA aa946deView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0afc7f - Browse repository at this point
Copy the full SHA b0afc7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebccc97 - Browse repository at this point
Copy the full SHA ebccc97View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5e112a - Browse repository at this point
Copy the full SHA a5e112aView commit details
Commits on Jun 15, 2016
-
Implement all types needed for the public API
The public API shouldn't expose any types from rss or atom_syndication, so this adds all the necessary types.
Configuration menu - View commit details
-
Copy full SHA for e30b0d4 - Browse repository at this point
Copy the full SHA e30b0d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3b6b49 - Browse repository at this point
Copy the full SHA b3b6b49View commit details -
Add Guid type since the RSS Guid is more detailed than the Atom one.
Configuration menu - View commit details
-
Copy full SHA for 3ffcfea - Browse repository at this point
Copy the full SHA 3ffcfeaView commit details -
Add conversions between our Entry and RSS's Entry
Add the Image and TextInput types to support the change.
Configuration menu - View commit details
-
Copy full SHA for bbf50f9 - Browse repository at this point
Copy the full SHA bbf50f9View commit details -
Derive Debug, PartialEq, Eq, & Clone when possible
EntryData and FeedData need an explicitly implementation of Debug because the atom types don't support it, and we probably don't want to show the contained feeds anyway.
Configuration menu - View commit details
-
Copy full SHA for c11d7ef - Browse repository at this point
Copy the full SHA c11d7efView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa0b250 - Browse repository at this point
Copy the full SHA aa0b250View commit details
Commits on Apr 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for fb9cb37 - Browse repository at this point
Copy the full SHA fb9cb37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24e3df4 - Browse repository at this point
Copy the full SHA 24e3df4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.