test_run.py: some QoL tweaks to the test_run script #131
Conversation
...and use this is a format string. This will help with later re-factoring. Signed-off-by: Alex Bennée <[email protected]>
stsquad
requested review from
andreeaflorescu,
gsserge,
lauralt,
sameo,
roypat and
JonathanWoollett-Light
as code owners
Rather than make developers dive into the json configuration provide a little introspection command line to list the available tests. Signed-off-by: Alex Bennée <[email protected]>
If the user specifies any tests on the command line then only run those. Signed-off-by: Alex Bennée <[email protected]>
stsquad
force-pushed
the
more-introspection
branch
from
262f262
to
09f4273
Compare
| @@ -66,4 +76,5 @@ def retrieve_test_list(config_file=f"{PARENT_DIR}/.buildkite/test_description.js | |||
| setattr(TestsContainer, f"test_{name}", test_func) | |||
|
|
|||
| if not args.list_tests: | |||
| unittest.main(verbosity=2) | |||
| tests_suite = unittest.TestLoader().loadTestsFromTestCase(TestsContainer) | |||
| unittest.TextTestRunner(verbosity=2).run(tests_suite) | |||
There was a problem hiding this comment.
Why is this needed? Why is the if + continue not enough above?
There was a problem hiding this comment.
Fun story - I'm not sure. I was running into weird errors where it was erroring out and I couldn't figure out why. I had a chat (http://ix.io/4API) with gpt4 which suggested the change which worked. It's reasoning might be off but it seemed to imply that the unittests had already been parsed meaning the updated attributes didn't take effect. However I don't understand the guts of the unit test framework enough. The loading of the tests_suite seemed sane though.
There was a problem hiding this comment.
I do not fully understand why it worked before and no longer does... The GPT explanation does not make sense to me, since the class starts off empty in both cases.
Maybe this is a bit easier?: https://paste.centos.org/view/8c66c3ef. Not sure if the __name__ assignment is a lot better though...
This adds some simple QoL improvements for those trying to run individual tests from the command line.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.