Remove providers from default features #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 20 20
Lines 4225 4225
=======================================
Hits 4108 4108
Misses 117 117 ☔ View full report in Codecov by Sentry. |
djc
reviewed
Dec 23, 2024
djc
approved these changes
Dec 23, 2024
ctz
force-pushed
the
jbp-no-default-provider
branch
from
6a18c95 to
c1c2a7b
Compare
This uncovers that ci was broken for ring-alone, as aws-lc-rs was still built for `rcgen`, but nothing was asking for prebuilt-nasm. Fix that by setting the environment variable.
ctz
force-pushed
the
jbp-no-default-provider
branch
from
c1c2a7b to
c9be7e0
Compare
Yep, definitely intentional. I also plan to do a breaking PR for rustls/pki-types#27 -- downstream I am needing to take a dependency on this crate just to reuse consts from |
cpu
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #264