Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GitHub Action for testing #268

Closed
wants to merge 14 commits into from
Closed

Improve GitHub Action for testing #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6eedcb6
Update testing.yml
cthoyt Feb 4, 2022
738cea2
Add Mac OS
cthoyt Feb 4, 2022
5a3413b
Update testing.yml
cthoyt Feb 4, 2022
3355d15
Use coverage
cthoyt Feb 4, 2022
fa95e93
Update testing.yml
cthoyt Feb 4, 2022
ecec5b6
Update setup.py
cthoyt Feb 4, 2022
cf595fa
Update testing.yml
cthoyt Feb 4, 2022
b0175ba
Update setup.py
cthoyt Feb 4, 2022
6682490
Update testing.yml
cthoyt Feb 4, 2022
1720a13
Update testing.yml
cthoyt Feb 4, 2022
3c46a2c
Update setup.py
cthoyt Feb 4, 2022
2600426
Update setup.py
cthoyt Feb 4, 2022
15af45a
Update setup.py
cthoyt Feb 4, 2022
18679be
Merge branch 'master' into patch-2
cthoyt Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
python-version: [3.7]
python-version: ["3.7", "3.10"]
torch-version: [1.11.0, 1.12.0]

steps:
Expand All @@ -31,6 +31,8 @@ jobs:

- name: Install main package
run: |
# the -e/--editable flag is required otherwise the following error is raised:
# ImportError: Could not find module '_version_cpu' in /home/runner/work/pytorch_scatter/pytorch_scatter/torch_scatter
pip install -e .[test]

- name: Run test-suite
Expand Down
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ def get_extensions():
return extensions


install_requires = []
install_requires = ['torch']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have my problems with this, but mostly only due to bad experience in the past. For example, it is impossible for me to install the sentence-transformers library since due to whatever reasons PyTorch will always get re-installed.

It also looks like pip install torch-scatter will still fail when no PyTorch version is installed, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will see if I can replicate this problem using some clean virtual environments

setup_requires = []

test_requires = [
'pytest',
Expand Down