Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: symfony6 #128

Open
wants to merge 24 commits into
base: 3.x
Choose a base branch
from
Open

Conversation

Chris53897
Copy link

@Chris53897 Chris53897 commented Feb 7, 2023

superseeds #126 #123

  • improve ci
  • ....

@Chris53897
Copy link
Author

I tried to fix the ci errors.
@rvanlaak Can you please approve the ci run?

@Chris53897
Copy link
Author

Chris53897 commented Feb 7, 2023

The newest ci run should be green. I changed ci to run on forks. That makes it easier.

I tried to took the changes from #125
But i am not sure if i should take the changes from the following files.

  • Controller/SettingsController.php
  • Resources/config/routing.yml
  • Resources/config/services.yml

This needs a real world project to test.

But i guess we need to change dmishh/settings-bundle in a lot of places to rvanlaak/settings-bundle?

@rvanlaak WDYT?

@Chris53897
Copy link
Author

Should this PR target PHP 8.1? #124 (comment)

@rvanlaak
Copy link
Owner

rvanlaak commented Feb 7, 2023

Your PR now is doing a lot of things at the same time.

Would it be hard to not bump the PHP requirement and drop the CI tests, but to add Symfony 6 support? Would be great if we could add that as last minor release in the current 3.x branch, and finally release an actual stable version in the 3.x branch.

We could then thereafter in a new v4.x major release focus on dropping PHP < 8.1 and Symfony < 5.4 LTS support.

@Chris53897
Copy link
Author

Maybe branch the actual 3.x to 4.x and this PR will target the new 4.x Branch.
The included minor changes can be repeated for 3.x.
So this PR does not have to be changed, and we still can make minor releases for 3.x

@rvanlaak
Copy link
Owner

rvanlaak commented Feb 7, 2023

Would you be willing to help with making a new small PR for adding Symfony 6 support for the 3.x branch?

We can then indeed thereafter focus on making this PR fit on the newly to create 4.x branch.

@Chris53897
Copy link
Author

I have to think about this. Symfony 6 requires php > 8.0 and Symfony 6.1 php > 8.1. Symfony 6.2 is the only version with support at this time https://symfony.com/releases

User need php 8.1 to run Symfony 6.2.
I do not see the need to backport all changes to 3.x.
3.x still need CI-Updates and of course security fixes.

@rvanlaak
Copy link
Owner

rvanlaak commented Feb 7, 2023

There is no hard requirement to bump the PHP requirement on a bundle to match the Symfony version.

It is perfectly fine to keep supporting PHP 7.4 with our code, and let users themselves make the decision to upgrade Symfony to v6.0 or v6.1 (and thereby possibly the PHP version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants