-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: symfony6 #128
base: 3.x
Are you sure you want to change the base?
feat: symfony6 #128
Conversation
Symfony 3.4, 4.4, 5.3- removed
* Upgrading nyholm/symfony-bundle-test * Fixing PhpStan configuration
Removing psr/cache:2 and less
I tried to fix the ci errors. |
The newest ci run should be green. I changed ci to run on forks. That makes it easier. I tried to took the changes from #125
This needs a real world project to test. But i guess we need to change @rvanlaak WDYT? |
Should this PR target PHP 8.1? #124 (comment) |
Your PR now is doing a lot of things at the same time. Would it be hard to not bump the PHP requirement and drop the CI tests, but to add Symfony 6 support? Would be great if we could add that as last minor release in the current 3.x branch, and finally release an actual stable version in the 3.x branch. We could then thereafter in a new v4.x major release focus on dropping PHP < 8.1 and Symfony < 5.4 LTS support. |
Maybe branch the actual |
Would you be willing to help with making a new small PR for adding Symfony 6 support for the We can then indeed thereafter focus on making this PR fit on the newly to create |
I have to think about this. Symfony 6 requires php > 8.0 and Symfony 6.1 php > 8.1. Symfony 6.2 is the only version with support at this time https://symfony.com/releases User need php 8.1 to run Symfony 6.2. |
There is no hard requirement to bump the PHP requirement on a bundle to match the Symfony version. It is perfectly fine to keep supporting PHP 7.4 with our code, and let users themselves make the decision to upgrade Symfony to v6.0 or v6.1 (and thereby possibly the PHP version). |
superseeds #126 #123