Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allophone State Fsa bug for arc's weight leaving silence #14

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Allophone State Fsa bug for arc's weight leaving silence #14

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
75ada4a
correcting the arc's weight for leaving silence in the allophone stat…
Marvin84 Apr 13, 2022
158f193
new tdp applicator with context
Marvin84 Apr 17, 2022
647b3a1
architecture refactoring for TransitionModel to support fsa bug fix
Marvin84 Nov 21, 2022
b7c6949
corrected comment
Marvin84 Nov 24, 2022
eb57c4b
minor comment change
Marvin84 Nov 24, 2022
da605ad
better naming and scoped enum for applicator and tying type
Marvin84 Nov 29, 2022
dd692ab
reversed back eo classic enum
Marvin84 Nov 30, 2022
c0113c3
corrected scoped enums for transition type and applicator
Marvin84 Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Am/ClassicTransducerBuilder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,10 @@ typedef std::unordered_map<MinimizedState, Fsa::State*, MinimizedState::Hash,
* phone0 the first state of a phone segment
* phone1 the second state of a phone segment
*
* silence.exit = silence.forward - phone?.forward but why?
* silence.exit = silence.forward - phone?.forward due to epsilon arcs. This happens in the legacy
* LegacyApplicator that is buggy, and has been corrector by implementing
* CorrectedApplicator, where the weights are read by refering to the correct source state
* in case we have an epsilon arc
**/
Fsa::ConstAutomatonRef ClassicTransducerBuilder::createEmissionLoopTransducer(
bool transitionModel) {
Expand Down
Loading