Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotLayer argument simplifications #739

Closed
albertz opened this issue Nov 8, 2021 · 4 comments
Closed

DotLayer argument simplifications #739

albertz opened this issue Nov 8, 2021 · 4 comments
Assignees

Comments

@albertz
Copy link
Member Author

albertz commented Jan 4, 2022

Note, in principle, DotLayer would not need any options anymore, as we can infer all the information about what axes to reduce and what axes are shared. However, I think it is good to have to specify the reduce axes explicitly. Maybe we could however omit this when the user specifies out_shape.

@Zettelkasten
Copy link
Member

The reduce arg is always needed to distinguish it from the common axes, right?
(Okay, you could infer it from out_shape as it is not present there but the common axes are.)

@albertz
Copy link
Member Author

albertz commented Jan 4, 2022

The reduce arg is always needed to distinguish it from the common axes, right? (Okay, you could infer it from out_shape as it is not present there but the common axes are.)

Ah yes you are right.

@albertz
Copy link
Member Author

albertz commented Jan 4, 2022

I think all the main features for DotLayer are implemented now, so this can be closed.

@albertz albertz closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants