Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #666, broadcast no longer matches dims #864

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Fix #666, broadcast no longer matches dims #864

merged 4 commits into from
Dec 17, 2021

Conversation

Zettelkasten
Copy link
Member

@Zettelkasten Zettelkasten commented Dec 16, 2021 •
edited by albertz
Loading

Needs #863 first (which should be ready now).

Fix #666.

Introduces a new behavior version (#508) because it would break some older configs.

@Zettelkasten Zettelkasten marked this pull request as ready for review December 16, 2021 17:48
@Zettelkasten Zettelkasten requested review from albertz and a team as code owners December 16, 2021 17:48
@albertz

This comment has been minimized.

Sign in to view
@Zettelkasten
Copy link
Member Author

Ok, try now.
Sorry, I wasn't so clear about this, but the branch for this PR branched off #683, that is why the tests here also worked (and okay, we could've also closed #683 and just merged this directly).

albertz
albertz reviewed Dec 16, 2021
View reviewed changes
returnn/tf/util/data.py Outdated Show resolved Hide resolved
albertz
albertz reviewed Dec 16, 2021
View reviewed changes
returnn/tf/layers/basic.py Outdated Show resolved Hide resolved
@albertz albertz changed the title Fix #666 CombineLayer etc, Data.get_common_data, no broadcast_matches Dec 16, 2021
@albertz

This comment has been minimized.

Sign in to view
@albertz

This comment has been minimized.

Sign in to view
@Zettelkasten Zettelkasten changed the title CombineLayer etc, Data.get_common_data, no broadcast_matches Fix #666, broadcast no longer matches dims Dec 17, 2021
@albertz albertz merged commit af7a588 into master Dec 17, 2021
@albertz albertz deleted the frithjof-666 branch December 17, 2021 11:19
@albertz albertz mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertz albertz albertz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CombineLayer and others (Data.get_common_data) should use broadcast_matches=False
2 participants
@Zettelkasten @albertz