Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved sandbox.rocky.tf to rllab.tf #130

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Moved sandbox.rocky.tf to rllab.tf #130

wants to merge 2 commits into from

Conversation

jonashen
Copy link
Collaborator

@jonashen jonashen commented Jun 8, 2018

Upgraded tf to first-class citizenship. One caveat to note is a bug in yapf formatting of a couple files that results in CI failing. References here and here. In short, CI fails when encountering a comma after *args or **kwargs in code.

Ref: #84

@jonashen jonashen requested a review from ryanjulian June 8, 2018 21:34
Copy link
Owner

@ryanjulian ryanjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize the imports (but no other PEP8 changes) and then let me know when it's ready to force-submit.

@ryanjulian
Copy link
Owner

ryanjulian commented Jun 11, 2018

Please reopen this PR against https://github.com/rlworkgroup/garage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants