Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrappers for starting and stopping modal windows #129

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Add wrappers for starting and stopping modal windows #129

wants to merge 6 commits into from

Commits on Oct 3, 2024

  1. Add App::run_modal_for_window. 

    This is a wrapper around https://developer.apple.com/documentation/appkit/nsapplication/1428436-runmodalforwindow.
    @hwright
    hwright committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    377b244 View commit details
    Browse the repository at this point in the history

  2. Add wrapper for stopModalWithCode, and conversions for ModalResponse.

    @hwright
    hwright committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6f0ce1e View commit details
    Browse the repository at this point in the history

  3. Make run_modal_for_window borrow a reference, rather than take the va… 

    …lue.

The reference is needed because the caller may still need to use the
window after the dialog is finished.
    @hwright
    hwright committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    950b0ea View commit details
    Browse the repository at this point in the history

  4. Add a note about using the sheets API for modal views.

    @hwright
    hwright committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0473c4f View commit details
    Browse the repository at this point in the history

  5. Move the ModalResponse enum from the filesystem module to the appkit:… 

    …:app module.

It is now being used outside of filesystem, and this more closely mirrors
the location of this enum with AppKit.
    @hwright
    hwright committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    77aa94e View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Make run_modal_for_window have the same semantics as begin_sheet. 

    Specifically, allow windows with delegates to be used.
    @hwright
    hwright committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    4046f91 View commit details
    Browse the repository at this point in the history