Add default settings for formatting Rzk files #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this be enough to close #25? |
fizruk
previously approved these changes
Dec 7, 2023
fizruk
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the extension itself as the default formatter (using LSP, which depends on the upcoming release of Rzk) for Rzk files, while also adding other relevant sensible defaults.
I also contemplated adding
but I'm not if the formatter is ready enough for that. It can cause frustration to users who prefer not to opt in for the formatter, especially that they are not used to it existing in Rzk (coming with the next release). What do you think?
Edit: received reply privately: it should be turned on by default, since users can disable the formatter