Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirements file #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

GilLevi
Copy link

@GilLevi GilLevi commented Dec 31, 2022

The requirements file was not updated, casing a few small issues when running pip install -e . and trying to run the demo.

  1. torchvision version is not specified, thus pip tries to install the latest version which is not compatible with torch 1.10.0, added torchvision==0.11.1 to the requirements file which is the compatible version.
  2. The scriptlavis/models/img2prompt_models/img2prompt_vqa.py requires spacy, but it was not reflected in the requirements file resulting in an import error when running the demo, added spacy to the requirement file.
  3. spacy requires a specific version of pydantic, see issue in spacy repo here, added pydantic==1.10.2 to the requirements file.

Overall small changes, but hopefully it will save a 10 minutes of debugging to the next person:)

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @GilLevi to sign the Salesforce.com Contributor License Agreement.

@GilLevi
Copy link
Author

GilLevi commented Dec 31, 2022

This is weird, I signed the CLA, but the PR still has the cls:missing label.
Screenshot 2022-12-31 at 16 24 13

@nick-konovalchuk
Copy link
Contributor

nick-konovalchuk commented Jan 4, 2023

This is weird, I signed the CLA, but the PR still has the cls:missing label.

Nah, it seems to work like this all the time

@GilLevi
Copy link
Author

GilLevi commented Jan 4, 2023

Thanks @bottledmind, hope it will get merged then.

@nick-konovalchuk
Copy link
Contributor

The VQA pipeline still requires an en_core_web_sm model. I've created #77 with a hacky way of solving this issue. If you have a better idea, merge it to this PR and inform me to remove mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants