Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clouds file #36

Merged
merged 9 commits into from
Aug 13, 2023

Conversation

natalieswork
Copy link
Contributor

What does this PR do?

This pull request aims to update the extension's Azure Resource Manager Cloud Module by refactoring old functions to utilize Execution Modules that perform the same tasks. The goal is to improve code maintainability and reduce code redundancy while ensuring the functionality remains intact.

Commits signed with GPG?

No

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (6d2fbde) 81.22% compared to head (128ec59) 81.22%.

❗ Current head 128ec59 differs from pull request most recent head 7c05ba5. Consider uploading reports for the commit 7c05ba5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files           5        5           
  Lines         293      293           
  Branches       32       32           
=======================================
  Hits          238      238           
  Misses         45       45           
  Partials       10       10           
Flag Coverage Δ
Linux 81.22% <ø> (ø)
project 71.68% <ø> (ø)
py310 81.22% <ø> (ø)
salt_3006_1 81.22% <ø> (ø)
tests 93.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natalieswork natalieswork marked this pull request as ready for review July 25, 2023 15:54
@nicholasmhughes nicholasmhughes merged commit 65af324 into salt-extensions:main Aug 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants