Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed object dump in collectd.python #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed object dump in collectd.python #127

wants to merge 1 commit into from

Conversation

Logioniz
Copy link

@Logioniz Logioniz commented Apr 13, 2018

Wrong dump python object with quotes (need double quotes)

Actual behavior

Pillar:

collectd:
  plugins:
    python:
      modules:
        elasticsearch:
          variables:
            AdditionalMetrics: [""]

Generated file:

    <Module "elasticsearch">
        AdditionalMetrics ['']
        ...
    </Module>

Error

collectd[1581]: configfile: Cannot read file `/etc/collectd/plugins/python.conf'.
systemd[1]: Unit collectd.service entered failed state.
collectd[1581]: ['']

Expected behavior

    <Module "elasticsearch">
        AdditionalMetrics [""]
        ...
    </Module>

{%- elif value is sequence %}
{{ key }} {{ value | json() }}
{%- else %}
{{ key }} {{ value }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as on line 26, you could therefore simply test for is sequence and have a single else branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants