Skip to content

Commit

Permalink
Updated selinux commands and tests after reviewer comments, need the …
Browse files Browse the repository at this point in the history
…extra space
  • Loading branch information
dmurphy18 committed Oct 24, 2024
1 parent 335561c commit d9a6021
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion salt/modules/selinux.py
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ def _fcontext_add_or_delete_policy(
if "add" == action:
# need to use --modify if context for name file exists, otherwise ValueError
filespec = re.escape(name)
cmd = f"semanage fcontext -l | grep -E '{filespec}'"
cmd = f"semanage fcontext -l | grep -E '{filespec} '"
current_entry_text = __salt__["cmd.shell"](cmd, ignore_retcode=True)
if current_entry_text != "":
action = "modify"
Expand Down
4 changes: 2 additions & 2 deletions tests/pytests/unit/modules/test_selinux.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def test_selinux_add_policy_regex(name, sel_type):
):
selinux.fcontext_add_policy(name, sel_type=sel_type)
filespec = re.escape(name)
expected_cmd_shell = f"semanage fcontext -l | grep -E '{filespec}'"
expected_cmd_shell = f"semanage fcontext -l | grep -E '{filespec} '"
mock_cmd_shell.assert_called_once_with(
expected_cmd_shell,
ignore_retcode=True,
Expand Down Expand Up @@ -433,7 +433,7 @@ def test_selinux_add_policy_shorter_path(name, sel_type):
):
selinux.fcontext_add_policy(name, sel_type=sel_type)
filespec = re.escape(name)
expected_cmd_shell = f"semanage fcontext -l | grep -E '{filespec}'"
expected_cmd_shell = f"semanage fcontext -l | grep -E '{filespec} '"
mock_cmd_shell.assert_called_once_with(
expected_cmd_shell,
ignore_retcode=True,
Expand Down

0 comments on commit d9a6021

Please sign in to comment.