Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master]WIP: Add no_spaces option to remove spaces around separator in ini file #60081

Closed
wants to merge 2 commits into from

Conversation

MurzNN
Copy link

@MurzNN MurzNN commented Apr 25, 2021

What does this PR do?

Added new option no_spaces that controls adding spaces around separator in ini file.

What issues does this PR fix or reference?

Fixes: #33669

Previous Behavior

There is no ability to disable adding spaces around separator in ini files

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Added new option `no_spaces` that controls adding spaces around separator in ini file.
@MurzNN MurzNN requested a review from a team as a code owner April 25, 2021 04:48
@MurzNN MurzNN requested review from dwoz and removed request for a team April 25, 2021 04:48
@welcome
Copy link

welcome bot commented Apr 25, 2021

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will require a changelog and test coverage

@dwoz
Copy link
Contributor

dwoz commented Dec 10, 2023

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

@dwoz dwoz closed this Dec 10, 2023
@dwoz dwoz added help-wanted Community help is needed to resolve this Abandoned labels Dec 10, 2023
@sscotter
Copy link

sscotter commented May 24, 2024

Apologies if this is a newbie error (I've only been using Salt a matter of weeks) but I think the white space around seperator "bug" is still present.

I'm running the following version across a pair of Debian and Ubuntu test hosts.

salt-minion --version
salt-minion 3007.1 (Chlorine)

The following state file...

file_etc_systemd_timesyncd.conf:
  ini.options_present:
    - name: /etc/systemd/timesyncd.conf.d/local.conf
    - separator: '='
    - sections:
        Time:
          NTP: ntp1.domain.local

... produces the following content in /etc/systemd/timesyncd.conf.d/local.conf ...

[Time]
NTP = ntp1.example.local

While the output doesn't break functionality in this case, I personally think it doesn't read well and more importantly seems to be at odds to the fix apparently remediated by #33669

@twangboy twangboy reopened this Aug 20, 2024
@twangboy twangboy requested a review from a team as a code owner August 20, 2024 17:57
@twangboy twangboy changed the base branch from master to 3006.x August 20, 2024 17:59
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title WIP: Add no_spaces option to remove spaces around separator in ini file [3006.x]WIP: Add no_spaces option to remove spaces around separator in ini file Aug 20, 2024
@twangboy twangboy changed the base branch from 3006.x to master August 20, 2024 18:00
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [3006.x]WIP: Add no_spaces option to remove spaces around separator in ini file [master]WIP: Add no_spaces option to remove spaces around separator in ini file Aug 20, 2024
@twangboy twangboy closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned help-wanted Community help is needed to resolve this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ini.options_present adds unnecessary whitespaces
5 participants