-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added datetime encoder for json #61971
base: master
Are you sure you want to change the base?
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
@MKLeb Can you please review this? |
Hi @abhi1693, would you mind adding tests as well? |
@abhi1693 Any updates here? |
@MKLeb Hey sorry, I got side tracked from this. I'm on vacation this week. I'll work on this either this weekend or next Monday. |
@abhi1693 Thanks for circling back to this one. This will just need tests and then I'll see if we can get it merged. |
I have been trying to get nox to work but it's stuck installing for last few hours |
@MKLeb I need some help with the unit tests. I have not yet made any changes and it's failing. I tried to run the unit test on the master branch and it's failing on my system.
I'm unable to figure out which module has the wrong file permissions |
@abhi1693 I believe it is pointing to the test module, |
@dwoz I have changed the code to make the linter happy. It works on my local system on Linux with Python 3.10 |
@s0undt3ch and @dwoz I have made all changes, can this be reviewed and merged now? |
@s0undt3ch @dwoz Can you please review this? |
@dwoz @s0undt3ch Guys, it's been 2 years and it's an incredibly small change. I have done everything that's been asked but this review process is incredibly slow to get past. If it's not going to be merged, let me know. I'll look for alternatives like Ansible because we are stuck on a very old release due to this bug |
What does this PR do?
What issues does this PR fix or reference?
Fixes: #59952
Previous Behavior
New Behavior
The above error is handled appropriately
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.