Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyring param to gpg modules, final cleanup #63179

Merged
merged 18 commits into from
Dec 11, 2023
Merged

Conversation

lkubb
Copy link
Contributor

@lkubb lkubb commented Dec 2, 2022

What does this PR do?

  • Adds keyring param to all functions (if sensible)
  • Adds option to delete empty keyring file to gpg.absent
  • Finally brings all functions up to speed by having user, gnupghome and keyring (if sensible)
  • Adds functional tests for both modules
  • Fixes some miscellaneous bugs surfaced by the tests
  • Corrects documentation

Todo:

  • add gnupghome and keyring to trust_key
  • check why gpg.decrypt test is failing on older systems
  • read the docs and correct some more errors

This is based on #63162, so that one would have to be merged before. PR has been merged.

What issues does this PR fix or reference?

Fixes: #59783

Previous Behavior

always uses default keyring

New Behavior

keyring can be specified

Merge requirements satisfied?

Commits signed with GPG?

Yes

@lkubb lkubb force-pushed the gpg-keyring branch 10 times, most recently from a6309f2 to ef191cc Compare December 5, 2022 10:26
@lkubb lkubb marked this pull request as ready for review December 5, 2022 14:14
@lkubb lkubb requested a review from a team as a code owner December 5, 2022 14:14
@lkubb lkubb requested review from garethgreenaway and removed request for a team December 5, 2022 14:14
@lkubb lkubb force-pushed the gpg-keyring branch 5 times, most recently from 682604f to 7654046 Compare December 11, 2022 18:16
@twangboy twangboy added this to the Chlorine v3007.0 milestone May 8, 2023
salt/modules/gpg.py Outdated Show resolved Hide resolved
@lkubb
Copy link
Contributor Author

lkubb commented Dec 11, 2023

@twangboy Can we still get this into 3007? This PR has celebrated its first birthday recently.

@dwoz dwoz merged commit 61b172a into saltstack:master Dec 11, 2023
515 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] gpg states and module should accept path to keyring file
3 participants