[3006.x] [code-coverage] Added support for smb testing, and ported smb test from unittest to pytest #65570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
dmurphy18
changed the title
s0undt3ch
suggested changes
Nov 16, 2023
Signed-off-by: Pedro Algarvio <[email protected]>
dmurphy18
force-pushed
the
ccov_smb_b102
branch
from
451e929
to
4cc7ad2
Compare
whytewolf
approved these changes
Mar 12, 2024
|
Closing this in favor of #66227 which doesn't have the Py 3.7 issues and clashes in requirements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added support for smb testing, and ported smb test from unittest to pytestd, adding smbprotocol, and pyspnego pinned dependencies.
Need to add samba support to Golden Images for smbd to be available
What issues does this PR fix or reference?
Fixes:#64747
Previous Behavior
SMB testing was skipped due to smbprotocol and smbd not being available
New Behavior
SMB testing is now enabled, once smbd (samba) is added to Golden Images.
Testing is on Linux platforms only.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.