[master] Make reactor engine less blocking the EventPublisher #66158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
3 tasks
vzhestkov
force-pushed
the
make-reactors-engine-less-blocking
branch
from
329a4c4
to
abaf59c
Compare
|
This change needs tests and a changelog. |
vzhestkov
force-pushed
the
make-reactors-engine-less-blocking
branch
from
abaf59c
to
c1dba43
Compare
|
@whytewolf sorry, I've missed the notification. Not sure about the test is it good enough, but the idea is to move the process to the separate thread as soon as possible. |
vzhestkov
force-pushed
the
make-reactors-engine-less-blocking
branch
from
c1dba43
to
9d78994
Compare
|
@vzhestkov hey there. unfortunately i don't really do much with salt anymore. I left the core team. I am tagging @dwoz in reviewing this. |
|
Seems this change has some negative effect in combination with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
reactorengine in some cases could cause blocking on reading the events from EventPublisher so it has to hold the events until they will be retrived by the engine.This change improves the way of handling the events by the
reactorengine by pushing more work to the thread pool which is already available inside the engine, in this case more work is handled with the distinct thread instead of performing this work with the main thread of thereactorengine.Previous Behavior
In some cases could cause some growth of the memory consumption with
EventPublisheras it has to hold the events to be consumed by the stream fromreactorengine.New Behavior
The events from the stream from
EventPublisherare handled faster.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.