-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Make deb scripts more compliant with Debian policy #66688
base: 3006.x
Are you sure you want to change the base?
Conversation
fe03c81
to
6732121
Compare
To me, my PR is working fire, the generated scripts now looks like this:
|
6732121
to
8fd0a7d
Compare
I fixed the |
Yes, please keep it up to date if possible. |
This dependency is required for ordering scripts to make sure `salt-cloud.postinst` can access debconf `salt-master/user`.
408dc76
to
a03b1bd
Compare
The failing tests don't seem to be related to my PR, right? |
What does this PR do?
What issues does this PR fix or reference?
Fixes #66507
Previous Behavior
When upgrading debian salt packages, the current status of the services are not managed:
Status of the services before upgrade
Error log during upgrade
Status of the services after failed upgrade
New Behavior
The upgrade should work with masked services and keep previous status after upgrade.
I can't test it because I did not find the way to build custom packages to test
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.