-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Add tests for the Windows Installer #66708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Add tests for the Windows Installer
[3006.x] Add tests for the Windows Installer
Jul 12, 2024
twangboy
force-pushed
the
nsis_tests
branch
10 times, most recently
from
July 12, 2024 21:28
3aebea4
to
f9a32b3
Compare
twangboy
force-pushed
the
nsis_tests
branch
2 times, most recently
from
July 16, 2024 17:32
e0c1a8e
to
b6cd29f
Compare
dwoz
added
test:pkg
Run the package tests
test:os:all
Run Tests Against ALL OS'es
labels
Jul 16, 2024
dwoz
approved these changes
Jul 16, 2024
Akm0d
approved these changes
Jul 16, 2024
dmurphy18
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a hang issue with the NullSoft installer for Windows
Adds a stress test for the installer which install and uninstalls 100 times
Adds config tests to ensure install scenarios are handled properly
What issues does this PR fix or reference?
Fixes
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes