Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][3006.x]Enabling group permissions for ipc #66804

Closed
wants to merge 4 commits into from

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Aug 12, 2024

What does this PR do?

Allows group permissions on IPC, publish_pull.ipc, master_event_pull.ipc, master_event_pub.ipx and worker.ipc, so non-root users have appropriate access, for example: members of group salt.

What issues does this PR fix or reference?

Fixes #66228

Previous Behavior

non-root users in the salt group (and in publisher_acl) can not start jobs.

New Behavior

non-root users in the salt group (and in publisher_acl) can not start jobs.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 added this to the Sulfur v3006.10 milestone Aug 12, 2024
@dmurphy18 dmurphy18 self-assigned this Aug 12, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner August 12, 2024 21:51
@Sxderp
Copy link

Sxderp commented Aug 13, 2024

I think the only socket that needs to be opened is master_event_pub.ipc. I didn't know about the def secure method, but I didn't need to mess with it to fix the issue in my PR.

#66752

@dmurphy18 dmurphy18 closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants