[3006.x]Manage symlinks after dirs and files #66857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
dmurphy18
previously approved these changes
Aug 28, 2024
bdrx312
reviewed
Aug 28, 2024
bdrx312
reviewed
Sep 12, 2024
bdrx312
reviewed
Sep 12, 2024
bdrx312
approved these changes
Sep 12, 2024
dwoz
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix intermittent issue with
file.recurseand symlinks.What issues does this PR fix or reference?
Fixes #64630
Previous Behavior
The state would fail saying that the file was missing.
There seems to be a race condition where it is comparing the hash of the symlinked target file before it is present.
New Behavior
The state finishes successfully. It does the symlink hashing last to make sure the target files are present.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes