Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Include the VM name with the IP address for Libvirt cloud logging #66860

Open
wants to merge 2 commits into
base: 3006.x
Choose a base branch
from

Conversation

m0duspwnens
Copy link

What does this PR do?

This PR adds the VM name to the log output for Libvirt when the IP address is reported. This is helpful when running salt-cloud in parallel with -P to know which IP address belongs to which host.

What issues does this PR fix or reference?

There is not an issue for this PR.

Previous Behavior

[INFO    ] Address = 10.66.166.111

New Behavior

[INFO    ] Address = 10.66.166.111 | Name = my_test_vm

Merge requirements satisfied?

If this is required for this change, then please let me know.

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@m0duspwnens m0duspwnens requested a review from a team as a code owner August 29, 2024 15:44
Copy link

welcome bot commented Aug 29, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Include the VM name with the IP address for Libvirt cloud logging [3006.x] Include the VM name with the IP address for Libvirt cloud logging Aug 29, 2024
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to have a changelog entry for the PR. Also are current tests sufficient for this or at least there should be a test which verifies that the correct VM name is reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants