Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3007.x][66799] Update master-cluster.rst Example Config #66916

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

kevin-andrew-wipro
Copy link

The Master Config example's file_roots and pillar_roots properties need the base property followed by a list of the directory. Otherwise, the Salt master shows an error in the logs.

What does this PR do?

Updates the documentation of the Master Cluster config.

I had to close #66822 in order to rebase my branch against 3007.x.

What issues does this PR fix or reference?

Incorrect example of the Master Cluster config.
Fixes 66799 [DOCS] Documentation Inconsistency

Previous Behavior

saltExample

New Behavior

Based on the example of file_roots here:
https://docs.saltproject.io/en/latest/ref/configuration/master.html#file-roots

we add base: to the config.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

The Master Config example's `file_roots` and `pillar_roots` properties need the `base` property followed by a list of the directory. Otherwise, the Salt master shows an error in the logs.
@kevin-andrew-wipro kevin-andrew-wipro requested a review from a team as a code owner September 23, 2024 19:00
@kevin-andrew-wipro
Copy link
Author

Hello, @twangboy , I have rebased against the 3007.x branch and tried to set the original PR to submit against the 3007.x branch. But in trying all of that, the PR got closed (#66822). So I had to open this new one.

@twangboy
Copy link
Contributor

No worries I'll try to get this one in.

@dwoz dwoz merged commit e4aa82f into saltstack:3007.x Sep 26, 2024
87 checks passed
Copy link

welcome bot commented Sep 26, 2024

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants