-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] The zmq socket poll method needs to be awaited #66926
Conversation
Just to clarify what I think is going on here. The async method is not awaited and thus returns the coroutine object. This object always evaluates to True and thus we hit the Anyway. Some things that may be worth considering: If The new test seems very similar to these: (tcp) salt/tests/pytests/functional/transport/zeromq/test_pub_server_channel.py Lines 249 to 283 in e4aa82f
(zeromq) salt/tests/pytests/functional/transport/tcp/test_pub_server.py Lines 9 to 65 in e4aa82f
With a few key differences.
Does it make more sense to make a more generic "transports" test that tests ALL the transports (WebSocket is missing these tests) and ensure the PublishClient / PublishServer work with both inet and unix sockets ( |
When using zmq.asyncio.Context, the socket's poll method is a coroutine.
18a7754
to
b1c716d
Compare
When using zmq.asyncio.Context, the socket's poll method is a coroutine.
What does this PR do?
What issues does this PR fix or reference?
Fixes #65265
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.