Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Fix urlunparse for salt file urls on python-3.12 #66948

Closed
wants to merge 1 commit into from
Closed

[master] Fix urlunparse for salt file urls on python-3.12 #66948

wants to merge 1 commit into from

Commits on Oct 8, 2024

  1. Fix urlunparse for salt file urls 

    Previously, the `salt.utils.url.create()` method naively assumed the
compiled URL provided by `urllib.parse.urlunparse()` always starts with
the literal string `file:///`, that is, the begininning of the URL
string starting with the `scheme` and including an empty `authority`
section.  Beginning with
[python-3.12](python/cpython@0edfc66),
however, generating a URL with `urlunparse()` results in the syntax
`file:` for the portion of the URL including the `scheme` and
`authority` sections.
    @jfindlay
    jfindlay committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4caba2d View commit details
    Browse the repository at this point in the history