Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Add cryptography back as a dependency for Salt 3006 to base.txt requirements #66977

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

dmurphy18
Copy link
Contributor

What does this PR do?

Adds cryptography as a dependency to base.txt requirements. This will ensure that cryptography is installed as a dependency when pip installing salt, currently even though it is present in static ci and pkg, it is not installed as a dependency, unlike Salt 3007.x where it is. Salt 3007.x has cryptography as a dependency in base.txt and it was added to 3007 by PR 4de6b10, a Merge 3006.x to 3007.x (circa 7th Feb 2024), but it must have been between tagged versions of 3006 since it does not exist in any tagged version of 3006.x

What issues does this PR fix or reference?

Fixes #66883

Previous Behavior

cryptography failed to install as a dependency of Salt 3006 when pip installed.

New Behavior

cryptography now installs as a dependency of Salt 3006 when pip installed.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dwoz dwoz merged commit 628c2d2 into saltstack:3006.x Oct 21, 2024
271 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants