Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master][Doc change] Update vmware.rst #66987

Closed
wants to merge 2 commits into from
Closed

Conversation

ZsBT
Copy link

@ZsBT ZsBT commented Oct 22, 2024

Fix command example for installing the pyVmomi python module.

The old page shows commands that do not install the dependency in the onedir package.

Fix command example for installing the pyVmomi python module.
@ZsBT ZsBT requested a review from a team as a code owner October 22, 2024 19:55
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [Doc change] Update vmware.rst [master][Doc change] Update vmware.rst Oct 22, 2024
@dmurphy18 dmurphy18 self-requested a review October 22, 2024 20:12
@dmurphy18 dmurphy18 added this to the Argon v3008.0 milestone Oct 22, 2024

.. code-block:: bash

pip install pyvmomi
easy_install pyvmomi
/opt/saltstack/salt/bin/pip3 install pyVmomi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /opt/saltstack/salt/bin/pip3 would be better replaced with salt-pip since the path can change depending on the platform.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, thanks for the finding.

suggests to use salt-pip
@ZsBT
Copy link
Author

ZsBT commented Oct 23, 2024

closing this in favor to a better pip command.

@ZsBT ZsBT closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants