Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master][Doc change] - replace pip command to a working version #66990

Closed
wants to merge 4 commits into from

Conversation

ZsBT
Copy link

@ZsBT ZsBT commented Oct 23, 2024

To suggest using salt-pip instead of the native pip.

Fix command example for installing the pyVmomi python module.
suggests to use salt-pip
@ZsBT ZsBT requested a review from a team as a code owner October 23, 2024 14:17
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [Doc change] - replace pip command to a working version [master][Doc change] - replace pip command to a working version Oct 23, 2024
doc/topics/cloud/vmware.rst Outdated Show resolved Hide resolved
@ZsBT
Copy link
Author

ZsBT commented Oct 24, 2024

cancelling PR due to improper package name

@ZsBT ZsBT closed this Oct 24, 2024
@dmurphy18
Copy link
Contributor

@ZsBT I think you need to read up on workflows with GitHub and using Git. FYI there was no reason to closed this PR and create a new PR for that change, you should have merely updated, committed and pushed up your changes. Closing and creating new PRs kills the history of the original PR and any comments or reviews made:

Example commands, after ensuring pre-commit install on your branch:

edit doc/topics/cloud/vmware.rst
git add doc/topics/cloud/vmware.rst
git commit
git push -u -f origin ZsBTpatch-1 (or whatever your branch name is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants