Skip to content

Commit

Permalink
OpTestPCI: Ignore harmless timeout message.
Browse files Browse the repository at this point in the history
When a sufficient amount of debugging has been enabled[0] Skiboot will
produce messages of the form
	PHB#0030[8:0]: TRACE: Timeout waiting for link up
This is harmless and only represents an empty slot so filter it out on
all platforms.

Fixes open-power#491

[0] nvram -p ibm,skiboot --update-config pci-tracing=true

Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
  • Loading branch information
sammj committed May 6, 2019
1 parent a9e85ac commit a566e0c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions testcases/OpTestPCI.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,10 @@ def pcie_link_errors(self):
total_entries = [l for l in total_entries if not fre.search(l)]
log.debug("P9DSU FILTERED OUT total_entries={}".format(total_entries))

# Ignore debugging messages about empty slots
fre = re.compile('TRACE: Timeout waiting for link up')
total_entries = [l for l in total_entries if not fre.search(l)]

msg = '\n'.join(filter(None, total_entries))
log.debug("total_entries={}".format(total_entries))
self.assertTrue( len(total_entries) == 0, "pcie link down/timeout Errors in OPAL log:\n{}".format(msg))
Expand Down

0 comments on commit a566e0c

Please sign in to comment.