Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly permit eg N+m in MM tag (PR#799) #799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicitly permit eg N+m in MM tag (PR#799) #799

wants to merge 1 commit into from

Commits on Oct 28, 2024

  1. Explicitly permit eg N+m in MM tag (PR#799) 

    The text already states that an unmodified base of N means we count
any base type, but base N code N in the table is a little misleading
as to the intention.  It was intended to mean any unspecified
modification, in the same way C+C is any unspecified C mod, but in
this case it's against all bases rather than a specific base type.

However that doesn't solve the issue of whether we can record specific
mods against any "fundamental" source base.  Clarified this by adding
an extra line to the table and some text.  (However note this doesn't
necessarily imply downstream processing tools will not do any
compatibility assessment and reject N+m when the SEQ base is a T.)

Fixes samtools#785
    @jkbonfield
    jkbonfield committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    03505ac View commit details
    Browse the repository at this point in the history