-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set date_created on each version as it is imported #2803
set date_created on each version as it is imported #2803
Conversation
@Cam156 I'm wondering if we might make |
@awead created a ticket: samvera/hydra-works#310 |
awesome. I can pick that up. |
I got the following error when doing a test run via my exe script:
|
@HackMasterA I had removed a line that I thought might not be needed. Your tests seem to show that it still is. Here https://github.com/projecthydra/sufia/pull/2803/files#diff-a89788817ebdbefb25061932f69b07e0R16 Give the new code a try and see if it fairs better. Thanks for thoroughly testing! |
Added new VersionUpdater to update the attribute before the version is created, which sets the metadata in stone
@Cam156 works now! |
@Cam156 are you still working on this? Not sure what is up with the tests. (otherwise ready to merge) |
@HackMasterA Not sure what is going on it passes on travis in psu-stewardship: https://travis-ci.org/psu-stewardship/sufia. I restarted them |
I'm seeing lots of Travis ⌚ this morning. |
@HackMasterA all green |
Fixes #2144. This PR sets the date so the work should now be complete.
Added new VersionUpdater to update the attribute before the version is created, which sets the metadata in stone
@projecthydra/sufia-code-reviewers