Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points Hyrax::EditPermissionsService.build_service_object_from to Hyrax configuration variable. #6768

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bwatson78
Copy link
Contributor

Summary

Points Hyrax::EditPermissionsService.build_service_object_from to Hyrax configuration variable.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

*This change should not alter any tested processing.

Type of change (for release notes)

  • notes-bugfix Bug Fixes
  • notes-valkyrie Valkyrie Progress

Detailed Description

For L#44, the if test's subject is hard-coded and unaware of any customized form class that the Hyrax Engine's implementers could create and set inside the Engine's configuration. This swaps to the configuration variable that defaults to the same hard-coded class (Hyrax::Forms::FileSetForm).

@samvera/hyrax-code-reviewers

@bwatson78 bwatson78 added bug valkyrization File Set impacts the File Set part of PCDM Model notes-valkyrie Release Notes: Valkyrie specific notes-bugfix Release Notes: Fixed a bug labels Apr 10, 2024
@bwatson78 bwatson78 requested a review from dlpierce April 10, 2024 19:07
@bwatson78 bwatson78 self-assigned this Apr 10, 2024
…ax configuration variable.

For L#44, the `if` test's subject is hard-coded and unaware of any customized form class that the Hyrax Engine's implementers could create and set inside the Engine's configuration. This swaps to the configuration variable that defaults to the same hard-coded class (`Hyrax::Forms::FileSetForm`).
@bwatson78 bwatson78 force-pushed the points_edit_permissions_service_to_hyrax_configuration_variable branch from e021d1a to 196fdcf Compare July 24, 2024 16:17
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

github-actions bot commented Jul 24, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 19m 0s ⏱️ - 2m 26s
 6 705 tests ±0   6 408 ✅ +1  297 💤 ±0  0 ❌  - 1 
13 178 runs  ±0  12 783 ✅ +1  395 💤 ±0  0 ❌  - 1 

Results for commit 196fdcf. ± Comparison against base commit 59a42ad.

This pull request removes 272 and adds 272 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f14897bd708>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fba83ec5c80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f148a194600>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fba83ffc450>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 133a9822-768b-48ad-a346-396b70d63b8b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d2a1f5ab-99e3-4f8a-af33-0f3fdb07e5a2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c5cdc4e2-8185-4228-a98c-b012fbea7e7f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 67871b8d-cc2d-4fee-8a21-c9ae70f921ec
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 84ed5efd-d6ce-4bf0-9187-6e1f28380843
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 7f6fdad7-4891-48e5-b492-1da2b3ab04db
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f373540fdd0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fab63586040>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3731c79880>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fab636b5650>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 53886012-8dfc-4c1d-ba44-2b09502d3375
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: eb2d8538-4bdb-4390-8b77-edd30f4fd820
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 4d9a70d4-4dc8-42ff-8358-f2edd15b001f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 42359a70-9713-4572-a831-17a3e2f937cc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 621457ba-bf39-4d9d-ba2c-dd61e72b1895
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 629577ed-fc4d-440c-83e9-79dbce168c8f
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug File Set impacts the File Set part of PCDM Model notes-bugfix Release Notes: Fixed a bug notes-valkyrie Release Notes: Valkyrie specific valkyrization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants