Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pinning sprockets at 3.7.2 #6828

Open
wants to merge 1 commit into
base: 4.x-stable
Choose a base branch
from
Open

pinning sprockets at 3.7.2 #6828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hyrax.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ SUMMARY
spec.add_dependency 'tinymce-rails', '~> 5.10'
spec.add_dependency 'valkyrie', '~> 3.0.1'
spec.add_dependency 'view_component', '~> 2.74.1' # Pin until blacklight is updated with workaround for https://github.com/ViewComponent/view_component/issues/1565
spec.add_dependency 'sprockets', '~> 3.7'
spec.add_dependency 'sprockets', '~> 3.7.2' # Pin at 3.7.2 as 3.7.3 creates PermissionsControl error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @cudevmaxwell noted this will allow 3.7.3. How about restricting to 3.7.x less than 3.7.3?

Suggested change
spec.add_dependency 'sprockets', '~> 3.7.2' # Pin at 3.7.2 as 3.7.3 creates PermissionsControl error
spec.add_dependency 'sprockets', '~> 3.7', '< 3.7.3' # Pin below 3.7.3 because it creates a PermissionsControl error

spec.add_dependency 'sass-rails', '~> 6.0'
spec.add_dependency 'select2-rails', '~> 3.5'

Expand Down