add contexts to the flexible metadata model. #6915
Conversation
…admin sets and then apply the contexts to the works made with that admin set selected
|
|
||
| # OVERRIDE disposable 0.6.3 to make schema dynamic | ||
| def schema | ||
| if Hyrax.config.flexible? |
There was a problem hiding this comment.
I assume the inclusion of this flexible? check is unnecessary, given that including this module is also conditioned by the flexible check. I'm curious if there is another reason for including it?
Or it's just there because it was directly moved over from the resource_form?
There was a problem hiding this comment.
correct, I'll take them out
| @@ -0,0 +1,5 @@ | |||
| class AddContextsToHyraxFlexibleSchemas < ActiveRecord::Migration<%= migration_version %> | |||
| def change | |||
There was a problem hiding this comment.
Should this migration have a conditional check if it already exists?
| @@ -18,6 +18,8 @@ classes: | |||
| contexts: | |||
| flexible_context: | |||
| display_label: Flexible Metadata Example | |||
| special_context: | |||
There was a problem hiding this comment.
Corresponding changes to this profile should probably also be made in the .koppie (and possibly .dassie?) versions, as well as the spec version.
There was a problem hiding this comment.
A few comments in addition to the above...
- the M3 profiles in specs, .koppie, and .dassie do not match the changes in the config profile. These need to be updated
- no specs exist for the code changes here
- the migration needs to also be added to koppie & dassie
- Admin set show page should display the selected metadata context if there is one
- I was unable to save a work with the dimensions term
This is the error I got trying to save the work using the context term. I'm not certain of the cause (my app crashed badly and I had to rebuild everything), but it originates on this line and the actual failure is when it calls definitions in the m3_schema_loader.
Co-authored-by: LaRita Robinson <[email protected]>
Co-authored-by: LaRita Robinson <[email protected]>
…/hyrax into context_feature_for_flex
they can be assigned on admin sets and then apply the contexts to the works made with that admin set selected